i only had problems with one shoulder, it still comes back if i do a lot of passing with no maintenance sessions in the gym. i dont do enough swimming to have loosened it through mileage!

i hate swimming.
i just have a few simple sets of exercises to balance the back of my shoulder, using light dumbells... i do them for both shoulders to keep things even, though one arm and shoulder is obviously more developed than the other from hockey and hangs lower, but i cant be stuffed doing anything about it for purely aesthetic reasons... just so long as they keep working!
holding the elbow close to the ribs and still, moving the dumbell out laterally straight, then at an angle, then with upper arm parallel with the floor... and a similar set of exercises using either stretch bands or light cable weights. i think they're pretty common exercises, ring bells carl? then i've just added on some sets of lateral raises, to the front and side, and reverse flys, with light weights concentrating on range of movement and good technique, using the back muscles and not the arm muscles. maybe some one armed rows if i'm getting bored?
so i end up with a maintenance session that i can either do by itself with a couple of larger back/shoulder exercises or tag onto the end of whatever other session i'm doing... and i can do a light version of it with a stretch band during a comp, which i have been doing for the last couple of worlds, as obviously you cant really do any gym sessions through the tourney.
it works good for me.
just make sure when you're doing stuff, you shouldnt be feeling clicking in your shoulders... lighten your weights and focus more on technique if you do. i'm just guessing on that though, can you enlighten me further on whats actually happening if you hear a click carl? i just assumed it cant be good and a couple of gym instructors have agreed with that. ...?